Skip updating Gradle when already updated #3794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Skip performing extra work when the current Gradle version was updated earlier in the cycle.
What's your motivation?
Overall reduce what would be considered duplicate work due to ordering within the recipe stack. For most cases, the stack will include Gradle updates that incrementally go higher. However, users may pull in recipes in varying orders, so we should ensure that we do the minimum amount of work necessary.
Anyone you would like to review specifically?
Any of: @jkschneider @sambsnyd @timtebeek
Have you considered any alternatives or workarounds?
Only one really is to try to strictly order recipes in the recipe stack as a user, so that things always go up and never down. Though this can be harder than it sounds.
Checklist