Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip updating Gradle when already updated #3794

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

shanman190
Copy link
Contributor

What's changed?

Skip performing extra work when the current Gradle version was updated earlier in the cycle.

What's your motivation?

Overall reduce what would be considered duplicate work due to ordering within the recipe stack. For most cases, the stack will include Gradle updates that incrementally go higher. However, users may pull in recipes in varying orders, so we should ensure that we do the minimum amount of work necessary.

Anyone you would like to review specifically?

Any of: @jkschneider @sambsnyd @timtebeek

Have you considered any alternatives or workarounds?

Only one really is to try to strictly order recipes in the recipe stack as a user, so that things always go up and never down. Though this can be harder than it sounds.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks for adding this logic!

@timtebeek timtebeek added the enhancement New feature or request label Dec 8, 2023
@shanman190 shanman190 merged commit 3770f85 into main Dec 8, 2023
1 check passed
@shanman190 shanman190 deleted the feature/gradle/update-once branch December 8, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants