Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder constructor arguments too #3713

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

joanvr
Copy link
Contributor

@joanvr joanvr commented Nov 20, 2023

What's changed?

Added support for constructors too

What's your motivation?

Needed in openrewrite/rewrite-migrate-java#338

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

Alternative to #3710

Checklist

  • I've added unit tests to cover both positive and negative cases

@joanvr joanvr added bug Something isn't working enhancement New feature or request labels Nov 20, 2023
@joanvr joanvr requested a review from timtebeek November 20, 2023 16:44
@joanvr joanvr self-assigned this Nov 20, 2023
@timtebeek timtebeek changed the title reorder constructor arguments too Reorder constructor arguments too Nov 20, 2023
@joanvr joanvr merged commit cc8ff8e into main Nov 20, 2023
@joanvr joanvr deleted the fix/reorder-method-constructor branch November 20, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants