Tentative fix for missing "//" operator on XPathMatcher
#3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
reviewed
Nov 20, 2023
| @@ -78,6 +88,33 @@ public boolean matches(Cursor cursor) { | |||
| Collections.reverse(path); | |||
| String[] parts = expression.substring(1).split("/"); | |||
|
|
|||
| // Deal with the two forward slashes in the expression; works, but I'm not proud of it. | |||
There was a problem hiding this comment.
Missed chance at using our @SelfLoathing(name= "...") annotation.
timtebeek
reviewed
Nov 20, 2023
| @@ -78,6 +88,31 @@ public boolean matches(Cursor cursor) { | |||
| Collections.reverse(path); | |||
| String[] parts = expression.substring(1).split("/"); | |||
|
|
|||
| // Deal with the two forward slashes in the expression; works, but I'm not proud of it. | |||
| if (expression.contains("//") && Arrays.stream(parts).anyMatch(StringUtils::isBlank)) { | |||
There was a problem hiding this comment.
What's the second part of the conditional meant to match? Since it seems as though we only reach here when Arrays.stream(parts).anyMatch(StringUtils::isBlank) would be true, given that the expression contains //, does not start with /, and is then split on /. Is it to skip cases that end in // which would not produce empty elements?
timtebeek
approved these changes
Nov 20, 2023
|
Decided to merge as is to not keep this open; since we specifically look at cases where the expression contains |
timtebeek
added a commit
to openrewrite/rewrite-migrate-java
that referenced
this pull request
Nov 22, 2023
Following on from openrewrite/rewrite#3707 Fixes #353
timtebeek
added a commit
to openrewrite/rewrite-migrate-java
that referenced
this pull request
Nov 28, 2023
* Update maven-compiler-plugin in pluginManagement Following on from openrewrite/rewrite#3707 Fixes #353 * Simplify test case to not use property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Changes
XPathMatcherto allow//syntax.What's your motivation?
openrewrite/rewrite-migrate-java#353
Anything in particular you'd like reviewers to focus on?
This is just enough to fix the before mentioned issue, definitely needs more testing and a better implementation.
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist
./gradlew licenseFormat