Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BitbucketBuildEnvironment for better progress indicators #3685

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

timtebeek
Copy link
Contributor

What's changed?

Add Bitbucket BuildEnvironment

What's your motivation?

Recognize bitbucket CI, such that the CLI progress bar adjusts output.

Anything in particular you'd like reviewers to focus on?

Any reason we didn't have this before?
Anything we should be mindful of in terms of detection order?

Have you considered any alternatives or workarounds?

We could detect CI only as a catch all CI env; but then we lack input for GitProvenance.

Any additional context

As per https://support.atlassian.com/bitbucket-cloud/docs/variables-and-secrets/

@timtebeek timtebeek added the enhancement New feature or request label Nov 13, 2023
@timtebeek timtebeek requested a review from kmccarp November 13, 2023 21:39
@timtebeek timtebeek self-assigned this Nov 13, 2023
@timtebeek timtebeek requested a review from joanvr November 13, 2023 21:49
@timtebeek
Copy link
Contributor Author

Looks like this needs another coordinate merge and deploy, because we're adding a marker.
@pstreef would you mind merging this one whenever is convenient for you as part of on-call?

@pstreef
Copy link
Contributor

pstreef commented Nov 15, 2023

sure, will do!

@pstreef pstreef merged commit 172657a into main Nov 17, 2023
@pstreef pstreef deleted the bitbucket_build_environment branch November 17, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants