Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix collision with nested class references #3669

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix collision with nested class references #3669

merged 2 commits into from
Nov 7, 2023
+50 −4

Conversation

joanvr
Copy link
Contributor

@joanvr joanvr commented Nov 7, 2023 •
edited
Loading

What's changed?

Checking for the root identifier on fieldAccess to add to usedTypes when referencing a nested type.

What's your motivation?

Fixes https://github.com/moderneinc/support-app/issues/20

Anyone you would like to review specifically?

@knutwannheden

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files

@joanvr joanvr requested a review from knutwannheden November 7, 2023 13:03
knutwannheden
knutwannheden approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@knutwannheden knutwannheden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

@joanvr joanvr merged commit a94650d into main Nov 7, 2023
@joanvr joanvr deleted the fix/shorten-nested-conflict branch November 7, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden knutwannheden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joanvr @knutwannheden