update method type on DeleteMethodArgument #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
approved these changes
Nov 3, 2023
joanvr
commented
Nov 3, 2023
Comment on lines
-68
to
+66
| new DeleteMethodArgument("B foo(int, int, int)", 1) | ||
| new DeleteMethodArgument("B foo(int, int)", 1) |
There was a problem hiding this comment.
Since we are updating the methodType, now it is required to match the new resulting "signature"
There was a problem hiding this comment.
Here is one case where that was required: openrewrite/rewrite-testing-frameworks@47ccd37
knutwannheden
added a commit
to openrewrite/rewrite-testing-frameworks
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Updating method type list of arguments to avoid next calls to the recipe to keep method matching
What's your motivation?
Right now this recipe is not idempotent, thus we need to specify in the tests that we only want one cycle. This is not very convenient when using this recipe from other recipes, and also leaves the method in an inconsistent state.
Anyone you would like to review specifically?
@timtebeek
Any additional context
I had to change a test, that was relying specifically on the fact that the method type is not updated and that subsequent calls to the recipe will still match and delete the parameter. I do not know if this is also used in recipes that are using this one.
Checklist
./gradlew licenseFormat