Fix parsing of unicode escape sequences in YAML #3604
Conversation
A YAML scalar value can contain unicode escape sequences like `\u0051`. Currently, this throws off the parser.
| @@ -400,34 +400,30 @@ void mappingAnchor() { | |||
| " '\\n' ", | |||
| " '\n' ", | |||
| " \n ", | |||
| " \"\\.\" ", | |||
There was a problem hiding this comment.
Note: I've removed the escape sequences which are illegal according to the SnakeYAML parser.
|
@nmck257 In #2264 you added logic to handle escape sequences. Unfortunately the tests inadvertently got disabled when we switched from Kotlin to Java. In this PR I have re-enabled the tests again, but I had to remove some of the cases, since the escape sequences appear to be invalid (at least according to the SnakeYAML parser). I was wondering if you could have a look at this PR and make sure that the implementation still meets your requirements. |
|
@knutwannheden yep, no concerns. I'll gladly trust the SnakeYaml parser; maybe some patch version over the past ~year helped it catch invalid edge cases which it did not notice before. |
|
Thanks a lot for taking a look! |
A YAML scalar value can contain unicode escape sequences like
\u0051. Currently, this throws off the parser.