Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid trailing blanks in SingleLineComment #3589

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Avoid trailing blanks in SingleLineComment #3589

merged 1 commit into from
Oct 1, 2023

Conversation

Bananeweizen
Copy link
Contributor

Fixes #3588.

What's changed?

No more trailing blanks being added by SingleLineComment

Checklist

  • I've added unit tests to cover both positive and negative cases

timtebeek
timtebeek approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Should help minimize unintended changes.

@timtebeek timtebeek merged commit e900928 into openrewrite:main Oct 1, 2023
@timtebeek timtebeek added the bug Something isn't working label Oct 1, 2023
@Bananeweizen Bananeweizen deleted the trailing_blank branch October 1, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

org.openrewrite.java.format.SingleLineComments adds trailing blank to empty comments
2 participants
@Bananeweizen @timtebeek