SimplifyBooleanExpression should only remove parens when related

The `SimplifyBooleanExpressionVisitor` should only remove unnecessary parentheses when the visitor already changed the parenthesized expression.
openrewrite · Dec 15, 2023 · b70c34b · b70c34b
1 parent dd5e502
commit b70c34b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...ite-java/src/main/java/org/openrewrite/java/cleanup/SimplifyBooleanExpressionVisitor.java b/...ite-java/src/main/java/org/openrewrite/java/cleanup/SimplifyBooleanExpressionVisitor.java
@@ -89,9 +89,9 @@ public J visitBinary(J.Binary binary, ExecutionContext ctx) {
     }
 
     @Override
-    public J postVisit(J tree, ExecutionContext ctx) {
-        J j = tree;
-        if (j instanceof J.Parentheses) {
+    public <T extends J> J visitParentheses(J.Parentheses<T> parens, ExecutionContext ctx) {
+        J j = super.visitParentheses(parens, ctx);
+        if (j != parens && j instanceof J.Parentheses) {
             j = new UnnecessaryParenthesesVisitor<>().visit(j, ctx, getCursor().getParentOrThrow());
         }
         return j;