Support varargs (improve test, show code breaking)

openrewrite · Dec 27, 2024 · b0fcbbc · b0fcbbc
1 parent 26d2d2c
commit b0fcbbc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java b/rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java
@@ -559,6 +559,7 @@ public void visitMethod(MethodNode method) {
                     paramType = visitTypeTree(param.getOriginType());
                 }
 
+                // TODO: propably better implementation, the `paramType` does not handle well when varargs + index operator is used
                 Space varargs = null;
                 if (paramType instanceof J.ArrayType) {
                     // E.g. foo(String... x)

diff --git a/rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/MethodDeclarationTest.java b/rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/MethodDeclarationTest.java
@@ -116,6 +116,7 @@ void varargsArguments() {
           groovy(
             """
               def foo(String... messages) {
+                  println(messages[0])
               }
               """
           )
-Original file line number
+Diff line change
@@ Expand Up / @@ -116,6 +116,7 @@ void varargsArguments() { @@
               groovy(
                 """
                   def foo(String... messages) {
+                      println(messages[0])
                   }
                   """
               )
@@ Expand Down @@