Fall back to default groupId when comparing plugins

Fixes openrewrite/rewrite-maven-plugin#745 As per openrewrite/rewrite-maven-plugin#745 (comment)
openrewrite · Feb 27, 2024 · 8a8d5ef · 8a8d5ef
1 parent d24949e
commit 8a8d5ef
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/rewrite-maven/src/main/java/org/openrewrite/maven/RemoveRedundantDependencyVersions.java b/rewrite-maven/src/main/java/org/openrewrite/maven/RemoveRedundantDependencyVersions.java
@@ -28,6 +28,7 @@
 
 import java.util.List;
 import java.util.Objects;
+import java.util.Optional;
 
 import static org.openrewrite.internal.StringUtils.matchesGlob;
 
@@ -176,7 +177,9 @@ && matchesGlob(d.getArtifactId(), exceptedArtifactId)) {
     @Nullable
     private static String getManagedPluginVersion(ResolvedPom resolvedPom, @Nullable String groupId, String artifactId) {
         for (Plugin p : resolvedPom.getPluginManagement()) {
-            if (Objects.equals(p.getGroupId(), groupId) &&
+            if (Objects.equals(
+                    Optional.ofNullable(p.getGroupId()).orElse("org.apache.maven.plugins"),
+                    Optional.ofNullable(groupId).orElse("org.apache.maven.plugins")) &&
                 Objects.equals(p.getArtifactId(), artifactId)) {
                 return resolvedPom.getValue(p.getVersion());
             }