Added classifier support to DependencyUseStringNotation recipe (#4226)

Co-authored-by: Jente Sondervorst <[email protected]>
openrewrite · Jun 5, 2024 · 85a4cce · 85a4cce
1 parent 5b5d72c
commit 85a4cce
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/rewrite-gradle/src/main/java/org/openrewrite/gradle/DependencyUseStringNotation.java b/rewrite-gradle/src/main/java/org/openrewrite/gradle/DependencyUseStringNotation.java
@@ -136,6 +136,10 @@ private J.Literal toLiteral(Space prefix, Markers markers, Map<String, Expressio
                     String version = coerceToStringNotation(mapNotation.get("version"));
                     if (version != null) {
                         stringNotation += ":" + version;
+                        String classifier = coerceToStringNotation(mapNotation.get("classifier"));
+                        if (classifier != null) {
+                            stringNotation += ":" + classifier;
+                        }
                     }
 
                     return new J.Literal(randomId(), prefix, markers, stringNotation, "\"" + stringNotation + "\"", Collections.emptyList(), JavaType.Primitive.String);

diff --git a/rewrite-gradle/src/test/java/org/openrewrite/gradle/DependencyUseStringNotationTest.java b/rewrite-gradle/src/test/java/org/openrewrite/gradle/DependencyUseStringNotationTest.java
@@ -58,6 +58,34 @@ void basicMap() {
         );
     }
 
+    @Test
+    void withClassifier() {
+        rewriteRun(
+          buildGradle(
+            """
+              plugins {
+                  id 'java-library'
+              }
+              
+              dependencies {
+                  api(group: 'org.openrewrite', name: 'rewrite-core', version: 'latest.release', classifier: 'sources')
+                  implementation group: 'group', name: 'artifact', version: 'version', classifier: 'sources'
+              }
+              """,
+            """
+              plugins {
+                  id 'java-library'
+              }
+              
+              dependencies {
+                  api("org.openrewrite:rewrite-core:latest.release:sources")
+                  implementation "group:artifact:version:sources"
+              }
+              """
+          )
+        );
+    }
+
     @Test
     void basicMapLiteral() {
         rewriteRun(