RemoveUnusedImports should retain explicit import when there are co…

…nflicting classes in the same package (#4482) * Add testcase * Apply feedback * Apply feedback: * fix whitespace * clearer test method name * clearer class name * Apply suggestions from code review --------- Co-authored-by: Tim te Beek <[email protected]>
openrewrite · Sep 10, 2024 · 7f14d4a · 7f14d4a
1 parent 7aed57c
commit 7f14d4a
Showing 1 changed file with 52 additions and 0 deletions.
diff --git a/rewrite-java-test/src/test/java/org/openrewrite/java/RemoveUnusedImportsTest.java b/rewrite-java-test/src/test/java/org/openrewrite/java/RemoveUnusedImportsTest.java
@@ -1983,4 +1983,56 @@ public void foo() {
           )
         );
     }
+
+    @Test
+    void retainExplicitImportWhenConflictingClassInSamePackage() {
+        rewriteRun(
+          java(
+            """
+              package com.a;
+
+              class ConflictingClass {
+              }
+              """,
+            SourceSpec::skip
+          ),
+          java(
+            """
+              package com.b;
+
+              public class ConflictingClass {
+                  public ConflictingClass() {
+                  }
+              }
+              """,
+            SourceSpec::skip
+          ),
+          java(
+            """
+              package com.c;
+
+              import com.b.ConflictingClass;
+
+              public class ImplProvider {
+                  static ConflictingClass getImpl(){
+                      return new ConflictingClass();
+                  }
+              }
+              """,
+            SourceSpec::skip
+          ),
+          java(
+            """
+              package com.a;
+
+              import com.b.ConflictingClass;
+              import com.c.ImplProvider;
+
+              class CImpl {
+                  ConflictingClass impl = ImplProvider.getImpl();
+              }
+              """
+          )
+        );
+    }
 }