Fix printing of false Javadoc attributes

This to ensure parse-to-print idempotency.
openrewrite · Oct 4, 2023 · 1670c01 · 1670c01
1 parent f36792d
commit 1670c01
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/rewrite-java-tck/src/main/java/org/openrewrite/java/tree/JavadocTest.java b/rewrite-java-tck/src/main/java/org/openrewrite/java/tree/JavadocTest.java
@@ -1707,4 +1707,23 @@ public static void main(String[] args) {
           )
         );
     }
+
+    @Test
+    void emptyAttributes() {
+        rewriteRun(
+          java(
+            """
+              /**
+               * DEFINE TENANCY TenantB AS <TenantB OCID>
+               * ENDORSE GROUP <TenantA user group name> TO {OBJECTSTORAGE_NAMESPACE_READ} IN TENANCY TenantB
+               *
+               * DEFINE TENANCY TenantA AS <TenantA OCID>
+               * DEFINE GROUP TenantAGroup AS <TenantA user group OCID>
+               * ADMIT GROUP TenantAGroup OF TENANCY TenantA TO {OBJECTSTORAGE_NAMESPACE_READ} IN TENANCY
+               */
+              class Test {}
+              """
+          )
+        );
+    }
 }
diff --git a/rewrite-java/src/main/java/org/openrewrite/java/JavadocPrinter.java b/rewrite-java/src/main/java/org/openrewrite/java/JavadocPrinter.java
@@ -35,7 +35,7 @@ public JavadocPrinter() {
     public Javadoc visitAttribute(Javadoc.Attribute attribute, PrintOutputCapture<P> p) {
         beforeSyntax(attribute, p);
         p.append(attribute.getName());
-        if (attribute.getSpaceBeforeEqual() != null) {
+        if (attribute.getSpaceBeforeEqual() != null && !attribute.getSpaceBeforeEqual().isEmpty()) {
             visit(attribute.getSpaceBeforeEqual(), p);
             if (attribute.getValue() != null) {
                 p.append('=');