Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JMockit to Mockito Recipe - Handle Typed Class Argument Matching and Collections #420

Merged
merged 11 commits into from
Nov 3, 2023
Merged

JMockit to Mockito Recipe - Handle Typed Class Argument Matching and Collections #420

merged 11 commits into from
Nov 3, 2023

Conversation

tinder-dthomson
Copy link
Contributor

@tinder-dthomson tinder-dthomson commented Oct 31, 2023 •
edited
Loading

What's changed?

What's your motivation?

Continuation of #419.

Handle JMockit typed argument matchers like mockInstance.anyMethod((List<String>) any).

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files

timtebeek
timtebeek reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciate the continued work on this! Let me know when this is ready to review & merge.

@tinder-dthomson
Copy link
Contributor Author

Much appreciate the continued work on this! Let me know when this is ready to review & merge.

Will do, I want to polish this a bit more - the code is getting tougher to read.

@timtebeek timtebeek added enhancement New feature or request recipe Recipe request labels Oct 31, 2023
@tinder-dthomson tinder-dthomson marked this pull request as ready for review November 2, 2023 04:25
@tinder-dthomson
Copy link
Contributor Author

@timtebeek ready for review & merge

timtebeek
timtebeek approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@timtebeek timtebeek merged commit 5c2367e into openrewrite:main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@tinder-dthomson tinder-dthomson

Labels
enhancement New feature or request recipe Recipe request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinder-dthomson @timtebeek