Refactor assertEquals(<boolean-literal>, …) and assertNotEquals(<boolean-literal>, …) to assertTrue or assertFalse
#417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammachado
force-pushed
the
assert-equals-boolean-to-assert-boolean
branch
from
4ace42e to
eec6d6a
Compare
timtebeek
approved these changes
Oct 24, 2023
src/main/java/org/openrewrite/java/testing/cleanup/AssertEqualsBooleanToAssertBoolean.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/cleanup/AssertNotEqualsBooleanToAssertBoolean.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/cleanup/AssertEqualsBooleanToAssertBooleanTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/cleanup/AssertNotEqualsBooleanToAssertBoolean.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/cleanup/AssertEqualsBooleanToAssertBoolean.java
Outdated
Show resolved
Hide resolved
...est/java/org/openrewrite/java/testing/cleanup/AssertNotEqualsBooleanToAssertBooleanTest.java
Outdated
Show resolved
Hide resolved
…>, ...)` to `assertTrue` or `assertFalse`
ammachado
force-pushed
the
assert-equals-boolean-to-assert-boolean
branch
from
eec6d6a to
389d333
Compare
|
Thanks a lot @ammachado ! You can try out this change through our snapshot versions. We'll follow up with a release soon. I'll also push this up to the Moderne platform such that you can try it out at scale there. |
|
Ran this again netflix conductor, with some results there: https://app.moderne.io/results/QtIfI8Wpq/details/eyJfX3R5cGVuYW1lIjoiR2l0SHViUmVwb3NpdG9yeSIsIm9yaWdpbiI6ImdpdGh1Yi5jb20iLCJwYXRoIjoiTmV0ZmxpeC9jb25kdWN0b3IiLCJicmFuY2giOiJtYWluIn0=?referrer=https%3A%2F%2Fapp.moderne.io%2Fresults%2FQtIfI8Wpq Confirmed to work; thanks again! And feel free to open that PR to conductor if you're up for it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Improves the current cleanup rules by refactoring
assertEquals(false, a.methodCall(...))toassertFalse(a.methodCall(...))Checklist
./gradlew licenseFormat