Add ReplaceMockBeanAndSpyBean Recipe #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/java/spring/boot3/ReplaceMockBeanAndSpyBean.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/spring/boot3/ReplaceMockBeanAndSpyBeanTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/spring/boot3/ReplaceMockBeanAndSpyBeanTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/spring/boot3/ReplaceMockBeanAndSpyBeanTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/spring/boot3/ReplaceMockBeanAndSpyBeanTest.java
Show resolved
Hide resolved
timtebeek
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Thanks for getting this started @123Haynes ! I wonder if we even need the Java class; perhaps a declarative recipe can work just as well if there's no annotation attributes to convert.
src/main/java/org/openrewrite/java/spring/boot3/ReplaceMockBeanAndSpyBean.java
Outdated
Show resolved
Hide resolved
123Haynes
force-pushed
the
mockandspybean
branch
from
cd38018 to
2cc1409
Compare
123Haynes
force-pushed
the
mockandspybean
branch
from
4384c74 to
ad7d0d3
Compare
123Haynes
force-pushed
the
mockandspybean
branch
from
ad7d0d3 to
408f88d
Compare
src/test/java/org/openrewrite/java/spring/boot3/ReplaceMockBeanAndSpyBeanTest.java
Show resolved
Hide resolved
…nAndSpyBeanTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Thanks @123Haynes ; looks great! Perfect first contribution and a good step up for Spring Boot 3.4 support.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR adds a recipe for replacing the deprecated annotations
@MockBeanand@SpyBeanwith@MockitoBeanand@MockitoSpyBeanWhat's your motivation?
Anything in particular you'd like reviewers to focus on?
This is the first recipe I've written as well as the first pr to this project. Please point out anything I might've done wrong 😄
Checklist