Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BeanMethodsNotPublic from SpringBoot2BestPractices (again) #645

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Remove BeanMethodsNotPublic from SpringBoot2BestPractices (again) #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d2c19b
Remove BeanMethodsNotPublic from SpringBoot2BestPractices (again)
nmck257 Dec 5, 2024
a17ea55
Merge branch 'main' into nmck257-patch-1
timtebeek Dec 5, 2024
1039113
Move the 2.x best practices to best-practices.yml as well
timtebeek Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/main/resources/META-INF/rewrite/best-practices.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,23 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.spring.boot2.SpringBoot2BestPractices
displayName: Spring Boot 2.x best practices
description: Applies best practices to Spring Boot 2 applications.
tags:
- spring
- boot
recipeList:
# Note that we do not upgrade to Spring Boot 2.x here, as the 2.0 recipe includes SpringBoot2BestPractices itself
- org.openrewrite.java.spring.NoRequestMappingAnnotation
- org.openrewrite.java.spring.ImplicitWebAnnotationNames
- org.openrewrite.java.spring.boot2.UnnecessarySpringExtension
- org.openrewrite.java.spring.NoAutowiredOnConstructor
- org.openrewrite.java.spring.boot2.RestTemplateBuilderRequestFactory
- org.openrewrite.java.spring.boot2.ReplaceDeprecatedEnvironmentTestUtils

---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.spring.boot3.SpringBoot3BestPractices
Expand All @@ -22,10 +39,12 @@ tags:
- spring
- boot
recipeList:
# These steps go above & beyond what's needed for a pure upgrade, and are not be included with 3.x upgrades themselves
- org.openrewrite.java.spring.boot2.SpringBoot2BestPractices
- org.openrewrite.java.migrate.UpgradeToJava21 # Allows for virtual threads
- org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_3
- org.openrewrite.java.spring.boot3.EnableVirtualThreads
- org.openrewrite.java.spring.framework.BeanMethodsNotPublic # Intentionally not in 2.x
# Replace literals with constants and simplify MediaType parse calls
- org.openrewrite.java.spring.http.ReplaceStringLiteralsWithHttpHeadersConstants
- org.openrewrite.java.spring.http.ReplaceStringLiteralsWithMediaTypeConstants
Expand Down
16 changes: 0 additions & 16 deletions src/main/resources/META-INF/rewrite/spring-boot-20.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,19 +168,3 @@ recipeList:
artifactId: validation-api
version: 2.x
onlyIfUsing: org.hibernate.validator.constraints.*
---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.spring.boot2.SpringBoot2BestPractices
displayName: Spring Boot 2.x best practices
description: Applies best practices to Spring Boot 2 applications.
tags:
- spring
- boot
recipeList:
- org.openrewrite.java.spring.NoRequestMappingAnnotation
- org.openrewrite.java.spring.ImplicitWebAnnotationNames
- org.openrewrite.java.spring.boot2.UnnecessarySpringExtension
- org.openrewrite.java.spring.NoAutowiredOnConstructor
- org.openrewrite.java.spring.boot2.RestTemplateBuilderRequestFactory
- org.openrewrite.java.spring.boot2.ReplaceDeprecatedEnvironmentTestUtils
- org.openrewrite.java.spring.framework.BeanMethodsNotPublic
Loading