-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle special case of xssProtection #625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/spring/boot2/ConvertToSecurityDslVisitor.java
- lines 18-19
- lines 33-32
src/main/java/org/openrewrite/java/spring/boot2/ConvertToSecurityDslVisitor.java
Outdated
Show resolved
Hide resolved
...ithSpringBoot_2_4/java/org/openrewrite/java/spring/boot2/HeadersConfigurerLambdaDslTest.java
Show resolved
Hide resolved
...ithSpringBoot_2_4/java/org/openrewrite/java/spring/boot2/HeadersConfigurerLambdaDslTest.java
Outdated
Show resolved
Hide resolved
...ithSpringBoot_2_4/java/org/openrewrite/java/spring/boot2/HeadersConfigurerLambdaDslTest.java
Outdated
Show resolved
Hide resolved
...ithSpringBoot_2_4/java/org/openrewrite/java/spring/boot2/HeadersConfigurerLambdaDslTest.java
Outdated
Show resolved
Hide resolved
...ithSpringBoot_2_4/java/org/openrewrite/java/spring/boot2/HeadersConfigurerLambdaDslTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the improved handling here @SiBorea , and your continued involvement throughout. Much appreciated!
...ithSpringBoot_2_4/java/org/openrewrite/java/spring/boot2/HeadersConfigurerLambdaDslTest.java
Outdated
Show resolved
Hide resolved
…ot2/HeadersConfigurerLambdaDslTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/testWithSpringBoot_2_4/java/org/openrewrite/java/spring/boot2/HeadersConfigurerLambdaDslTest.java
- lines 20-20
What's changed?
When it comes to
xssProtection
, the recipe will generate code likeprotection ->protection.xssProtectionEnabled(true)
. However,xssProtectionEnabled()
is removed in spring-security-config-6+. xssProtection is set enabled as default and disabled on demand.Checklist