Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored ConvertToSecurityDslVisitor to assemble target method type… #465

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

nmck257
Copy link
Collaborator

@nmck257 nmck257 commented Dec 15, 2023

…s "manually" instead of searching for them on some existing type's available methods, to fix a bug where ApplyToWithLambdaDsl did not work for projects parsed with an older version of Spring Security (aka the expected case for apps using the recipe to upgrade)

Anything in particular you'd like reviewers to focus on?

  • The resultant type information is slightly less robust with this change, but I'm pretty sure it should still be sufficient for the vast majority of recipe usages which might follow this recipe in a chain?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

…s "manually" instead of searching for them on some existing type's available methods, to fix a bug where ApplyToWithLambdaDsl did not work for projects parsed with an older version of Spring Security (aka the expected case for apps using the recipe to upgrade)
@timtebeek timtebeek added bug Something isn't working spring-security labels Dec 18, 2023
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Indeed a common source of issues when leaping from old versions to new. I've applied a very minor change, but otherwise looks good to me.

@timtebeek timtebeek merged commit 522c320 into main Dec 18, 2023
1 check passed
@timtebeek timtebeek deleted the bugfix/apply-to-with-from-old-version branch December 18, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spring-security
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants