Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve recipe descriptions #159

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Improve recipe descriptions #159

merged 1 commit into from
Jan 21, 2025

Conversation

mike-solomon
Copy link
Contributor

@mike-solomon mike-solomon commented Jan 21, 2025

To handle cases where special characters are wrapped in backticks.

To handle cases where special characters are wrapped in backticks.

Fixes: #158
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I fully follow that specialCharsOutsideBackticksRegex, but I trust that you've compared the before and after with the commands in the README to an improvement.

@mike-solomon
Copy link
Contributor Author

Not sure I fully follow that specialCharsOutsideBackticksRegex, but I trust that you've compared the before and after with the commands in the README to an improvement.

Yep I've tested it. I also don't truly understand it either - just asked meta to create that for me and it seemed to work 🤷

@mike-solomon
Copy link
Contributor Author

You can see what changes it resulted in here @timtebeek openrewrite/rewrite-docs@9946ef4

@mike-solomon mike-solomon merged commit 3455cb6 into main Jan 21, 2025
1 check passed
@mike-solomon mike-solomon deleted the improve-description branch January 21, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

DeclarationSiteTypeVariance documentation parser issue
2 participants