Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof that javax.jms is migrated to jakarta.jms in spring.xml #603

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

Laurens-W
Copy link
Contributor

What's changed?

Added a testcase to prove javax is migrated to jakarta in a spring.xml beans config file

Anyone you would like to review specifically?

@timtebeek @knutwannheden

Any additional context

Uses the Reference trait

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

… adapt the new `SourceFileWithReference` construction
@Laurens-W Laurens-W added the enhancement New feature or request label Nov 13, 2024
@Laurens-W Laurens-W self-assigned this Nov 13, 2024
@Laurens-W Laurens-W changed the title Proof that javax is migrated to jakarta in spring.xml Proof that javax.jms is migrated to jakarta.jms in spring.xml Nov 13, 2024
@timtebeek
Copy link
Contributor

Any idea what's causing the failure here? I see

J.VariableDeclarations joinColumn = (J.VariableDeclarations) new ChangeType(COLUMN, JOIN_COLUMN, false).getVisitor().visit(multiVariable, ctx, getCursor().getParentOrThrow());

So perhaps then another case of a fix through:

@Laurens-W Laurens-W merged commit 2ff26bc into main Nov 14, 2024
2 checks passed
@Laurens-W Laurens-W deleted the update-javax-in-spring-xml branch November 14, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants