Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Messages for invalid Recipe Configuration #633

Closed
wants to merge 1 commit into from

Conversation

motu55
Copy link

@motu55 motu55 commented Sep 27, 2023

What's changed?

The Error message for Invalid validations contain now the recie display name if present

What's your motivation?

see openrewrite/rewrite#3567 for motivation

Anything in particular you'd like reviewers to focus on?

requires the code in here openrewrite/rewrite#3567

Checklist

  • [x ] I've added unit tests to cover both positive and negative cases
  • [ x] I've added the license header to any new files through ./gradlew licenseFormat
  • [ x] I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek
Copy link
Contributor

Hi @motu55 ! Thanks for your help in improving the error messages shown when there are validation issues. In going over your changes I see a lot of unrelated changes; the order of methods has been changed, alternative formatting to JavaDocs and wild card imports exported. That makes it hard to see what the actual changes are, and causes conflicts as we use different standards for our own changes. Would you be able to reduce your change set to only the intentional changes, without the formatting changes your IDE might have automatically applied? That would give us a better chance of evaluating your changes for inclusion.

@timtebeek
Copy link
Contributor

Closing this PR due to inactivity, confusing reordering and reformat of code, which makes it hard to see what the intended changes are. In addition to this we've made improvements to how we validate recipes, such that such issues should surface earlier and in a clear manner. Hope that helps and you'll consider to contribute again, even if this one did not make it in.

@timtebeek timtebeek closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants