Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParameterizedLogging support for logger fields added through Lombok annotations #205

Merged
merged 4 commits into from
Dec 31, 2024

Conversation

nielsdebruin
Copy link
Contributor

What's changed?

Only tests

Openrewrite can convert log statements into parameterized log statements, often yielding substantial performance gain. However, currently, loggers that are generated through a Lombok annotation, e.g., @Slf4j, are not supported.

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek marked this pull request as ready for review December 31, 2024 13:07
@timtebeek timtebeek changed the title Parameterized logging for lombok loggers ParameterizedLogging support for logger fields added through Lombok annotations Dec 31, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this works already when Lombok support is enabled; then we know there's no work left to do here for now.

@timtebeek timtebeek merged commit 89f5789 into main Dec 31, 2024
2 checks passed
@timtebeek timtebeek deleted the feature/lombok-parameterized-logging branch December 31, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants