-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Javet, node, V8, tsc and node-gradle #70
Conversation
2d5dc34
to
2d068a5
Compare
Thanks for putting in the effort in here @ammachado ; had indeed noticed that parsing web resources takes a while on various projects, hope this helps speed that up. I'm not the best judge of the changes here, so I'm hoping @traceyyoshima is able to have a look. |
2d068a5
to
1fada0c
Compare
1fada0c
to
905c2c0
Compare
@timtebeek @traceyyoshima I added a test to reproduce the slowness. |
@ammachado Thanks for your work and your performance test. As you may have noticed this is still work in progress and not all syntactic constructs are supported yet. I did however commit some improvements now which should improve performance and also adds support for some constructs (e.g. the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ammachado, Thank you for the PR, and my apologies for taking so long to review the changes! Changes look good -- we'll make a few updates on our end so the build will pass. There was an API change, and a test fails due to an existing parsing issue unrelated to the PR>
@traceyyoshima I'm happy to help. |
What's changed?
Javet, node, V8 tsc and node-gradle have been updated
What's your motivation?
Running mod on Apache Camel was taking almost 1h. By observation on the progress bar, parsing of javascript files was slow, so I'm updating this project to test later
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist
./gradlew licenseFormat