Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Example for GeoCoords #251

Merged
merged 2 commits into from
Nov 28, 2024
Merged

ADD: Example for GeoCoords #251

merged 2 commits into from
Nov 28, 2024

Conversation

syedhamidali
Copy link
Contributor

  • Closes #xxxx
  • Tests added
  • Changes are documented in history.md

Adding example for Assigning GeoCoords to Radar DataTree

Related Issue #243

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (836a4c5) to head (f1a18b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files          26       26           
  Lines        5041     5041           
=======================================
  Hits         4717     4717           
  Misses        324      324           
Flag Coverage Δ
notebooktests 78.97% <ø> (+0.03%) ⬆️
unittests 93.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmuehlbauer
Copy link
Collaborator

@syedhamidali Very nice! Thanks for also addressing the issues with DOW's changing location!

@kmuehlbauer kmuehlbauer merged commit 0ea8d58 into openradar:main Nov 28, 2024
12 checks passed
@kmuehlbauer
Copy link
Collaborator

Thanks @syedhamidali, this will help users to better get along with georeferencing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants