Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: New feature to attach lat, lon, and alt #244

Closed
wants to merge 4 commits into from

Conversation

syedhamidali
Copy link
Contributor

Description

This PR is for the ability to include geographic coordinates (lat, lon, and alt) in xradar’s georeferencing accessor.

Usage

To enable geographic georeferencing

geo = radar.xradar.georeference(geo=True)

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.55%. Comparing base (b4684fa) to head (b0882ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   93.49%   93.55%   +0.05%     
==========================================
  Files          26       26              
  Lines        5028     5072      +44     
==========================================
+ Hits         4701     4745      +44     
  Misses        327      327              
Flag Coverage Δ
notebooktests 79.63% <100.00%> (+0.61%) ⬆️
unittests 93.13% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@syedhamidali
Copy link
Contributor Author

Closing this PR for now based on the discussion in #243.

@syedhamidali
Copy link
Contributor Author

We can add an example demonstrating @kmuehlbauer’s approach #243 (comment) while we wait for clarity on xarray’s CRS developments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Consider adding lat, lon and alt option in georeferencing
1 participant