Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attrs #242

Merged
merged 11 commits into from
Nov 16, 2024
Merged

Fix attrs #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
889420b
fixing sweep names and making open_nexradlevel2 5x faster
aladinor Nov 8, 2024
01b6147
Merge branch 'main' into nexrad-sweeps
mgrover1 Nov 13, 2024
cf4510b
using NodePath to ensure 'sweep' parameter
aladinor Nov 13, 2024
07c269f
adding test for sweeps argument
aladinor Nov 13, 2024
1189fc8
removing unnecesary tests
aladinor Nov 13, 2024
327f6de
documenting changes in history.md
aladinor Nov 13, 2024
1691527
fixing sweep number
aladinor Nov 13, 2024
d50769c
fixing deletion of attributes in dataset varibles
aladinor Nov 16, 2024
2cf815d
Merge branch 'main' into fix-attrs
aladinor Nov 16, 2024
84232b2
Change documented in history.md
aladinor Nov 16, 2024
b6d4309
Merge branch 'fix-attrs' of github.com:aladinor/xradar into fix-attrs
aladinor Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/history.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* ENH: Adding test to `open_datatree` function for all backends. Adding "scan_name" to nexradlevel2 datatree attributes ({pull}`238`) by [@aladinor](https://github.com/aladinor)
* FIX: Improving performance of `open_nexradlevel2_datatree` function and adding tests for `sweep` parameter. ({issue}`239`) ({pull}`240`) by [@aladinor](https://github.com/aladinor)
* FIX: Keeping attributes at each variable when using `open_nexradlevel2_datatree`. ({issue}`241`) ({pull}`242`) by [@aladinor](https://github.com/aladinor)

## 0.8.0 (2024-11-04)

Expand Down
2 changes: 1 addition & 1 deletion xradar/io/backends/nexrad_level2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1642,7 +1642,7 @@ def open_nexradlevel2_datatree(
# todo: refactor _assign_root and _get_subgroup to recieve dict instead of list of datasets.
# avoiding remove the attributes in the following line
sweep_dict = {
sweep_path: sweep_dict[sweep_path].drop_attrs()
sweep_path: sweep_dict[sweep_path].drop_attrs(deep=False)
for sweep_path in sweep_dict.keys()
}
dtree = dtree | sweep_dict
Expand Down