ADD: Add scan_name to nexrad datatree attributes #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 92.84% 93.52% +0.67%
==========================================
Files 26 26
Lines 5004 5004
==========================================
+ Hits 4646 4680 +34
+ Misses 358 324 -34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@aladinor - I think adding a test would be good here - other than that, this looks great! Thanks for the quick PR 👍 |
|
working on it! |
mgrover1
reviewed
Nov 8, 2024
|
I am finishing test for other backends. |
Co-authored-by: Max Grover <[email protected]>
|
Sounds good @aladinor - I can give it another review when you are ready! |
… adding-attrs-nexrad
3 tasks
mgrover1
approved these changes
Nov 13, 2024
mgrover1
changed the title
rcjackson
pushed a commit
to rcjackson/xradar
that referenced
this pull request
Nov 26, 2024
* adding scan_name to nexrad datatree attributes * adding test to furuno backend * adding test to nexradlevel2 backend * adding test for open_datatree in iris backend * adding changes to history.md file * adding changes to history.md file * Update docs/history.md Co-authored-by: Max Grover <[email protected]> * adding test to open_datatree for datamet backend * adding test to open_datatree for gamic backend * adding test to open_datatree for hpl backend * adding test to open_datatree for metek backend * adding test to open_datatree for odim backend * adding test to open_datatree for rainbow backend * updating history.md file --------- Co-authored-by: Max Grover <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
history.md