Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: pytests to missing funcs #228

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

syedhamidali
Copy link
Contributor

  • Closes #xxxx
  • Tests added
  • Changes are documented in history.md

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (fbbdd5d) to head (70ae29d).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   92.61%   92.79%   +0.18%     
==========================================
  Files          26       26              
  Lines        4957     4957              
==========================================
+ Hits         4591     4600       +9     
+ Misses        366      357       -9     
Flag Coverage Δ
notebooktests 78.93% <ø> (ø)
unittests 91.22% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmuehlbauer
Copy link
Collaborator

You can add an entry in the history.md before merge. This looks good now!

@syedhamidali
Copy link
Contributor Author

Related issues #156

@kmuehlbauer kmuehlbauer merged commit b88218e into openradar:main Oct 31, 2024
12 checks passed
@kmuehlbauer
Copy link
Collaborator

Thanks for tackling this @syedhamidali. Your efforts are much appreciated!

rcjackson pushed a commit to rcjackson/xradar that referenced this pull request Nov 26, 2024
* ADD: pytests to missing funcs
* ADD: Update history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants