Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update Readme #226

Merged
merged 9 commits into from
Oct 31, 2024
Merged

ENH: Update Readme #226

merged 9 commits into from
Oct 31, 2024

Conversation

syedhamidali
Copy link
Contributor

  • Closes #xxxx
  • Tests added
  • Changes are documented in history.md

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.61%. Comparing base (be4730e) to head (bdd0209).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   92.61%   92.61%           
=======================================
  Files          26       26           
  Lines        4957     4957           
=======================================
  Hits         4591     4591           
  Misses        366      366           
Flag Coverage Δ
notebooktests 78.93% <ø> (ø)
unittests 91.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@syedhamidali syedhamidali mentioned this pull request Oct 30, 2024
3 tasks
tests/io/test_iris.py Outdated Show resolved Hide resolved
@kmuehlbauer
Copy link
Collaborator

@syedhamidali I'd suggest that you remove all additional changes from this PR and add them as new PR. Then we can merge the Readme changes to have these changes in 0.8.0 (due tomorrow). Thanks!

tests/io/test_iris.py Outdated Show resolved Hide resolved
@kmuehlbauer
Copy link
Collaborator

You can add an entry in the history.md before merge.

@kmuehlbauer kmuehlbauer merged commit fbbdd5d into openradar:main Oct 31, 2024
12 checks passed
@kmuehlbauer
Copy link
Collaborator

Thanks @syedhamidali!

@syedhamidali syedhamidali deleted the readme-fix branch October 31, 2024 14:31
rcjackson pushed a commit to rcjackson/xradar that referenced this pull request Nov 26, 2024
* ENH: Update Readme
* ADD: Update history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants