-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Add the proper elevation angle to fixed angle #162
FIX: Add the proper elevation angle to fixed angle #162
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 21 21
Lines 3956 3956
=======================================
Hits 3612 3612
Misses 344 344
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly! 👍
@kmuehlbauer - I am not sure why it mentions we are taking a 1.7% hit in test coverage? |
@mgrover1 No, no idea. Let's just move on here. Maybe it's just intermittent? |
Seems ok now, no? |
yep! good to merge @kmuehlbauer ? |
Thanks @mgrover1 for the quick fix! |
Ensure the elevation angle is unpacked into the fixed angle variable, giving a numerical value instead of the ordered dictionary
history.md