Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Piccolo Proof of Concept #625

Open
wants to merge 5 commits into
base: integration
Choose a base branch
from

Conversation

DinoAGW
Copy link
Member

@DinoAGW DinoAGW commented Jun 12, 2020

  • First complete try to use Picolo as a config objectl and
  • fixed faulty package-info stuff.

hixel and others added 4 commits June 3, 2020 17:51
- short demo showing use of Picolo as a config objectl and
- fixed faulty package-info stuff.
FEAT: Piccolo Proof of Concept
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #625 into integration will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             integration     #625   +/-   ##
==============================================
  Coverage          45.63%   45.63%           
  Complexity          1046     1046           
==============================================
  Files                 57       57           
  Lines               9149     9149           
  Branches            1687     1687           
==============================================
  Hits                4175     4175           
  Misses              4424     4424           
  Partials             550      550           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f410a7f...2fd286e. Read the comment docs.

@carlwilson carlwilson added bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release labels Jun 12, 2020
@carlwilson
Copy link
Member

@david-russo and @tledoux I've asked you both to take a look at this as I know you'd both expressed opinions. I'm going to write some tests for illegal parameter combos and the like and add param descriptions. It also seems sensible to factor out the description strings as resources. That aside, it all looks good.

Copy link
Member

@david-russo david-russo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming all the TBD are addressed, and it supports at least what the current one does, the use of picocli already looks like a vast improvement to me. I don't see any problems with the logic either, it only seems to need some comment clean up and option descriptions.

Passing the old -P or -p options will now probably cause the CLI to exit with an 'unknown option' message of some kind (I haven't actually run the code). Those options have had no effect for a while though, so this is probably as good a time as any to alert people to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants