Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic update to Python 3 #224

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Basic update to Python 3 #224

merged 10 commits into from
Sep 11, 2024

Conversation

adamfarquhar
Copy link
Contributor

This PR does the following:

  • Moves installation to pyproject.toml from setup.py.

  • Simple upgrades Python 3. Dependencies that smoothed over the Python 2 to Python 3 upgrade have been removed, other work is not included.

  • Some modified files have have additional formatting changes introduced by ruff.

  • Moved query_yes_or_no from init.py to update_signatures.py, where it was used.

  • Removed from future import print_function

  • Removed from future import absolute_import

  • Removed use of cStringIO and replaced with IO.StringIO

  • Removed dependency six, including six.moves, six.moves.range, six.moves.iteritems, six.PY2, six.urllib

  • Removed dependency on importlib_resources

  • Removed pronom/http.py and added its one function into pronom/soap.py

  • Updated the .gitignore file to include more artefacts, such as .ruff_cache.

  • Deleted files are currently moved to the .attic folder.

Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm never sure what Python prefers regarding string quotes but we are consistent now which has got to be an improvement. Good to see the back of six.

@carlwilson carlwilson changed the base branch from main to rel/1.8 September 11, 2024 12:48
@carlwilson carlwilson merged commit 54cb23f into rel/1.8 Sep 11, 2024
4 of 5 checks passed
@carlwilson carlwilson deleted the dev/switch-to-pyproject branch September 23, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants