Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor neighbors, leiden UMAP into separate workflow. #942

Merged
merged 10 commits into from
Jan 13, 2025

Conversation

DriesSchaumont
Copy link
Member

@DriesSchaumont DriesSchaumont commented Dec 30, 2024

Changelog

Merge #941 first!
Refactor neighbors, leiden UMAP into separate workflow.

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont changed the base branch from main to deprecate_publish December 30, 2024 13:19
@DriesSchaumont DriesSchaumont marked this pull request as ready for review December 30, 2024 13:22
@DriesSchaumont DriesSchaumont added this to the 2.1.0 milestone Jan 6, 2025
@dorien-er
Copy link
Contributor

Code LGTM, but the integration tests are still failing atm

@DriesSchaumont
Copy link
Member Author

Code LGTM, but the integration tests are still failing atm

They worked after merging main:
https://github.com/openpipelines-bio/openpipeline/actions/runs/12672539414

@dorien-er
Copy link
Contributor

Code LGTM, but the integration tests are still failing atm

They worked after merging main: https://github.com/openpipelines-bio/openpipeline/actions/runs/12672539414

Aren't those the unit tests? There's some other integration tests failing here: https://github.com/openpipelines-bio/openpipeline/actions/runs/12655368361

@DriesSchaumont
Copy link
Member Author

Code LGTM, but the integration tests are still failing atm

They worked after merging main: https://github.com/openpipelines-bio/openpipeline/actions/runs/12672539414

Aren't those the unit tests? There's some other integration tests failing here: https://github.com/openpipelines-bio/openpipeline/actions/runs/12655368361

You're right, I was thinking about another PR 🙄 I'm running the tests now

@DriesSchaumont DriesSchaumont changed the base branch from deprecate_publish to main January 9, 2025 12:24
@DriesSchaumont DriesSchaumont changed the base branch from main to deprecate_publish January 9, 2025 12:26
@DriesSchaumont DriesSchaumont changed the base branch from deprecate_publish to main January 10, 2025 08:15
@DriesSchaumont
Copy link
Member Author

Integration tests are green now: https://github.com/openpipelines-bio/openpipeline/actions/runs/12689751983

@DriesSchaumont DriesSchaumont merged commit 1c38575 into main Jan 13, 2025
2 checks passed
@DriesSchaumont DriesSchaumont deleted the refactor_neighbors_leiden_umap branch January 13, 2025 08:20
DriesSchaumont added a commit that referenced this pull request Jan 13, 2025
DriesSchaumont added a commit that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants