Cell type annotation: Harmony/KNN workflow #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorien-er
changed the title
* cellranger mkgtf component working and tested * removed comments * changelog entry added * test unique attribute in result * multiple attribute par added * removed unused packages * use pytest, multiple attributes tested --------- Co-authored-by: DriesSchaumont <[email protected]>
Co-authored-by: Dries Schaumont <[email protected]>
* cellranger mkgtf component working and tested * removed comments * changelog entry added * test unique attribute in result * multiple attribute par added * removed unused packages * use pytest, multiple attributes tested --------- Co-authored-by: DriesSchaumont <[email protected]>
dorien-er
force-pushed
the
harmony-knn-annoation-workflow
branch
from
6bcfac3 to
e2049f1
Compare
There was a problem hiding this comment.
LGTM! But I will probably need to have a look at #948 first
DriesSchaumont
approved these changes
Feb 24, 2025
dorien-er
added a commit
that referenced
this pull request
Feb 26, 2025
Co-authored-by: Dries Schaumont <[email protected]> Co-authored-by: Jakub Majercik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
PR #960 and #959 need to be merged first!Workflow for harmony integration followed by KNN label transfer for cell type annotation.
Issue ticket number and link
Closes #xxxx (Replace xxxx with the GitHub issue number)
Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributor's guide
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI tests succeed!