Skip to content

test: add handling for skipped tests moved out of e2e/basepath/basepath.test.ts #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add handling for skipped tests moved out of e2e/basepath/basepath.test.ts #2970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/e2e-skip-retry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
"test/e2e/app-dir/revalidate-dynamic/revalidate-dynamic.test.ts",
"test/e2e/app-dir/rsc-basic/rsc-basic.test.ts",
"test/e2e/basepath.test.ts",
"test/e2e/basepath/basepath.test.ts",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to add this one here a couple weeks ago for the previous rename

"test/e2e/basepath/error-pages.test.ts",
"test/e2e/getserversideprops/test/index.test.ts",
"test/e2e/middleware-general/test/index.test.ts",
"test/e2e/module-layer/index.test.ts",
Expand Down
9 changes: 9 additions & 0 deletions tests/test-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@
]
},
{
"//": "These tests were in this file before v15.4.0-canary.32 extracted them to a new file",
"file": "test/e2e/basepath/basepath.test.ts",
"reason": "Hard-coded expectation of Vercel's default 404 page",
"tests": [
Expand All @@ -217,6 +218,14 @@
"basePath should show 404 for page not under the /docs prefix"
]
},
{
"file": "test/e2e/basepath/error-pages.test.ts",
"reason": "Hard-coded expectation of Vercel's default 404 page",
"tests": [
"basePath should not update URL for a 404",
"basePath should show 404 for page not under the /docs prefix"
]
Comment on lines +224 to +227
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there were three tests skipped here previously, but one of these is now passing so I didn't include it

},
{
"file": "test/e2e/app-dir/app/index.test.ts",
"reason": "Whitespace mismatch",
Expand Down
Loading