fix deploying Cloudflare:sockets and cloudflare email workers

[franz101]

Based on #661

[changeset-bot]

🦋 Changeset detected

Latest commit: 7c25c83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@opennextjs/cloudflare	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vicb]

Thanks!

Would cloudflare:* work here ?

[SamyPesse]

Yes, it should, also should it have node:*?

[vicb]

Yes, it should, also should it have node:*?

That is taken care of by platform: "node",

But we should have tests for cloudflare:* :)

[franz101]

how would you do this test?
open-next build worker.ts?

import "cloudflare:email";

export async function handler({
    return {}
}

[vicb]

Thanks for the change, could you please add a patch changeset (using pnpm changeset)

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@723

commit: 8172457

[franz101]

Currently running issues, when running

import 'cloudflare:email' in an API file

Maybe I forgot server-only or could be related to the next config:
vercel/next.js#50177 (reply in thread)

[franz101]

@vicb @vicb

need some support. it looks like opennext just bundles it into the following:
{var e5=Error("Cannot find module 'cloudflare:email'");throw e5.code="MODULE_NOT_FOUND",e5}) even with external libraries set

vercel/next.js#50177 (comment)

[sommeeeer]

What if you add it to serverExternalPackages in your next config?

[franz101]

What if you add it to serverExternalPackages in your next config?

Same error:
https://github.com/franz101/opennext-cf-email

[franz101]

ok I was able to run it locally. based on this:
https://github.com/cloudflare/next-on-pages/blob/3d84ab0096258febb88193c4b9d269ecbaf1b19b/packages/next-on-pages/src/buildApplication/buildWorkerFile.ts#L88

[franz101]

Requires this plugin:

export const builtInModulesPlugin = {
	name: 'built-in:modules',
	setup(build) {
		build.onResolve(
			{ filter: /^(node:|cloudflare:|async_hooks)/ },
			({ kind, path }) => {
				/**
				 * This plugin converts `require("<PREFIX>:*")` calls, those are the only ones that need
				 * updating (esm imports to "<PREFIX>:*" are totally valid), so here we tag with the
				 * built-in-modules namespace only imports that are require calls.
				 */
				return kind === 'require-call'
					? { path, namespace: 'built-in-modules' }
					: undefined;
			},
		);

		/**
		 * We convert the imports we tagged with the built-in-modules namespace so that instead of
		 * `require("<PREFIX>:*")` they import from `export * from "<PREFIX>:*";`
		 */
		build.onLoad(
			{ filter: /.*/, namespace: 'built-in-modules' },
			({ path }) => {
				return {
					contents: `export * from '${path}'`,
					loader: 'js',
				};
			},
		);
	},
};

  webpack: (config) => {
      config.externals.push('cloudflare:email');
      config.externals.push('cloudflare:socket');
      config.externalsType = 'commonjs';
    return config;
  }
};```

[franz101]

how would you design the test? it needs to be run with wrangler dev afaik