Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for cache adapter #596

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Add tests for cache adapter #596

merged 6 commits into from
Nov 4, 2024

Conversation

socsieng
Copy link
Contributor

@socsieng socsieng commented Oct 25, 2024 •
edited
Loading

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b683d61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socsieng socsieng force-pushed the tests/cache branch 2 times, most recently from 2f63a48 to db53555 Compare October 27, 2024 05:23
@socsieng socsieng marked this pull request as ready for review October 27, 2024 05:32
conico974
conico974 reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comment

packages/tests-unit/tests/adapters/cache.test.ts Outdated Show resolved Hide resolved
packages/tests-unit/tests/adapters/cache.test.ts Show resolved Hide resolved
packages/tests-unit/tests/adapters/cache.test.ts Show resolved Hide resolved
packages/tests-unit/tests/adapters/cache.test.ts Outdated Show resolved Hide resolved
packages/tests-unit/tests/adapters/cache.test.ts Outdated Show resolved Hide resolved
packages/tests-unit/tests/adapters/cache.test.ts Outdated Show resolved Hide resolved
packages/tests-unit/tests/adapters/cache.test.ts Outdated Show resolved Hide resolved
packages/tests-unit/tests/adapters/cache.test.ts Outdated Show resolved Hide resolved
packages/tests-unit/tests/adapters/cache.test.ts Outdated Show resolved Hide resolved
packages/tests-unit/tests/adapters/cache.test.ts Outdated Show resolved Hide resolved
conico974
conico974 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for that

packages/tests-unit/tests/adapters/cache.test.ts Show resolved Hide resolved
packages/tests-unit/tests/adapters/cache.test.ts Show resolved Hide resolved
@conico974 conico974 merged commit 3fe7852 into opennextjs:main Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@socsieng @conico974