TrailingSlash using rewrite for a fetch call results on infinite loop #280
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| return { | ||
| type: event.type, | ||
| statusCode: 308, | ||
| headers: { | ||
| Location: event.url.replace(/\/$/, ""), | ||
| Location: `${headersLocation[0].replace(/\/$/, "")}${headersLocation[1] ? `?${headersLocation[1]}` : ''}`, |
There was a problem hiding this comment.
Should the internalEvent.url in the final return below also split the ??
There was a problem hiding this comment.
I code-reviewed that part, and it is already handled by handleRewrites fn.
On handleRewrite, we are doing it like this:
const urlQueryString = new URLSearchParams(convertQuery(query)).toString();
const queryString = urlQueryString ? `?${urlQueryString}` : "";
let rewrittenUrl = rawPath;
url: `${rewrittenUrl}${queryString}`,
This should be working as expected because we do not add or remove any slash. On my changes, I've gone for split('?') because there are fewer lines of code. But happy to match the style. I'm not sure if there are some code style guidelines somewhere :D
There was a problem hiding this comment.
Should be fine, doesn't have to match style.
|
Fixed eslint. |
Fixes: #279