Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalizing update PET json's #262

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Conversation

bendhouseart
Copy link
Contributor

@bendhouseart bendhouseart commented Jan 23, 2024

Moving "generalize-able" methods out from more specified classes, updating ecat.py with lastest functionality in the process, and ultimately adding on CLI's.

CLI's will enable a user to input a pet json file and a dicom, spreadsheet, or ecat file to update the values within the supplied json.

Closes #255


📚 Documentation preview 📚: https://pet2bids--262.org.readthedocs.build/en/262/

@bendhouseart bendhouseart self-assigned this Jan 23, 2024
@bendhouseart
Copy link
Contributor Author

bendhouseart commented Jan 26, 2024

Mostly there, moved all of the shared json checking and updating functions into update_pet_json.py and added entry points for updating a pet json from either an ECAT or from a dicom to the command line to their respective places. Just need to make sure that check json and other PET based "QC" methods get applied to the newly minted command line versions. I was hoping to get this all into 1 command line function, but I see myself falling into circular imports with how things are currently set up for ECAT. I would really like to avoid that, so compromise for now.

Some day update json will take either dicom or ecat and be contained to a single function.

@bendhouseart bendhouseart merged commit 09a10bf into main Jan 30, 2024
16 checks passed
@bendhouseart bendhouseart deleted the 255-externalize-function branch January 30, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

externalize function
1 participant