Bug fix: enable dcm2niix json sidecar generation #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bilgelm can you close this and reopen it as a branch on this repo? I think that's why the CI isn't running as you don't have access to the credentials required to collect the test files in CI when you PR through your own fork. I know I could just make my own small PR, but I'd like to make sure that you have permissions to run the CI. Let me know if you have any other issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: No json output after running
dcm2niix4pet.Reason:
dcm2niixwasn't generating the initial json sidecar, so no json file was being included in the variablefiles_created_by_dcm2niix.Fix: Added
-b yargument todcm2niixenabled the generation of the initial json sidecar.