Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to quickstart #2

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

gab-arrobo
Copy link
Contributor

No description provided.

@llpeterson
Copy link
Contributor

Looks good. Moving the kubectl/helm paragarphs is an improvement. One suggestion, since you now include make in the install, you can remove it from the sentence:

Note that a fresh install of Ubuntu may be missing other packages that you need (e.g., git, curl, make), but you will be prompted to install them as you step through the Quick Start sequence.

@gab-arrobo
Copy link
Contributor Author

Looks good. Moving the kubectl/helm paragarphs is an improvement. One suggestion, since you now include make in the install, you can remove it from the sentence:

Note that a fresh install of Ubuntu may be missing other packages that you need (e.g., git, curl, make), but you will be prompted to install them as you step through the Quick Start sequence.

Sure

@gab-arrobo
Copy link
Contributor Author

Looks good. Moving the kubectl/helm paragarphs is an improvement. One suggestion, since you now include make in the install, you can remove it from the sentence:

Note that a fresh install of Ubuntu may be missing other packages that you need (e.g., git, curl, make), but you will be prompted to install them as you step through the Quick Start sequence.

BTW, with "you will be prompted", does it mean during the installation process. For example when executing make aether-k8s-install or other make target?
Also, I think git needs to be removed from the e.g., but this is a requirement to clone OnRamp. However, I think it already comes by default in Ubuntu

@llpeterson
Copy link
Contributor

For me (and it's been a while, so I'm going from memory), whenever one of the missing commands is first invoked (for example to clone the repo, or run make on the first target), I got the prompt to run apt install. The three commands listed as examples were ones that I had to retroactively install.

@gab-arrobo
Copy link
Contributor Author

For me (and it's been a while, so I'm going from memory), whenever one of the missing commands is first invoked (for example to clone the repo, or run make on the first target), I got the prompt to run apt install. The three commands listed as examples were ones that I had to retroactively install.

I got your point. I thought that the text was referring to getting a prompt to install a package when running a make target. Please see the latest changes

@llpeterson llpeterson merged commit c7d7fdb into opennetworkinglab:master Apr 10, 2024
2 checks passed
@gab-arrobo gab-arrobo deleted the docs-improvements branch April 10, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants