Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to replace component annotations with xml configurations #48

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

moshonk
Copy link
Contributor

@moshonk moshonk commented Aug 23, 2024

@mozzy11 please find the PR here

@moshonk moshonk requested a review from mozzy11 August 23, 2024 04:56
@mozzy11
Copy link
Member

mozzy11 commented Aug 26, 2024

Thanks @moshonk
Looks good to me.
Does every thing run fine after moving to xml based definitions and does this improve start up time??

@moshonk moshonk force-pushed the move-annotation-to-xml branch from 8e00547 to 276597c Compare September 7, 2024 10:50
@moshonk moshonk force-pushed the move-annotation-to-xml branch from 276597c to e597f18 Compare September 7, 2024 11:00
<developerConnection>scm:git:[email protected]:openmrs/openmrs-module-labonfhir.git</developerConnection>
<url>https://github.com/openmrs/openmrs-module-labonfhir/</url>
<tag>HEAD</tag>
<connection>scm:git:[email protected]:botswana-emrs/openmrs-module-labonfhir.git</connection>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moshonk do we need this change here??

@@ -201,6 +201,11 @@
</build>

<repositories>
<repository>
<id>repsy</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this repository here ??

@@ -254,4 +257,17 @@
<openmrsPlatformVersion>2.3.1</openmrsPlatformVersion>
<hapifhirVersion>4.2.0</hapifhirVersion>
</properties>
<distributionManagement>
<!-- Deploy to Github Packages -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moshonk This is already deployed to OpenMRS Artifactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants