(feat) O3-4066 : exclude stock issue from stock operation selector

[donaldkibet]

Requirements

• This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.

If applicable

• My work includes tests or is validated by existing tests.

Summary

See https://openmrs.atlassian.net/browse/O3-4066

Screenshots

Kapture.2024-10-08.at.14.47.25.mp4

GIF

Related Issue

Other

[github-actions]

Size Change: +5.33 kB (+0.47%)

Total Size: 1.15 MB

Filename	Size	Change
dist/973.js	0 B	-175 kB (removed)	🏆
dist/970.js	175 kB	+175 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size	Change
dist/172.js	5.48 kB	0 B
dist/20.js	1.4 kB	0 B
dist/26.js	24.1 kB	0 B
dist/271.js	4.02 kB	0 B
dist/273.js	144 kB	-1 B (0%)
dist/290.js	5.49 kB	0 B
dist/294.js	2.63 kB	0 B
dist/319.js	4.18 kB	0 B
dist/46.js	3.09 kB	0 B
dist/460.js	4.33 kB	0 B
dist/484.js	3.03 kB	0 B
dist/574.js	3.52 kB	0 B
dist/606.js	3.12 kB	0 B
dist/627.js	1.98 kB	0 B
dist/629.js	6.86 kB	0 B
dist/707.js	6.8 kB	0 B
dist/757.js	4.29 kB	0 B
dist/788.js	4.54 kB	0 B
dist/793.js	315 kB	0 B
dist/807.js	4.65 kB	0 B
dist/833.js	4.13 kB	0 B
dist/935.js	42.9 kB	0 B
dist/main.js	365 kB	+257 B (+0.07%)
dist/openmrs-esm-stock-management-app.js	3.53 kB	+67 B (+1.94%)
dist/511.js	2.24 kB	+2.24 kB (new file)	🆕
dist/870.js	2.58 kB	+2.58 kB (new file)	🆕

_{compressed-size-action}

[makombe]

Thanks @donaldkibet . I think this is in order since the stock issue operation was moved to happen/be initiated within the requisition. cc @jabahum

[ojwanganto]

Thanks, @donaldkibet and @makombe. Tagging @slubwama for his reviews.

[jabahum]

Are there no cases when stock issue alone without a requisition cc @slubwama

[slubwama]

@donaldkibet @jabahum you can actually issue stock without a requisition. In 2.x by default the issue button is not available but you can change the global property to make in available. That same flexibility is needed.

[ojwanganto]

Thanks, @slubwama. This is good guidance

[donaldkibet]

@slubwama updated the filtering to be based on the backend config as indicated. cc @jabahum

[ojwanganto]

Thanks, @donaldkibet

[jabahum]

Thanks @slubwama . Let me test this and get back to you @donaldkibet . cc @makombe

[jabahum]

from above if the global property is true/false i think under userrole scopes the operation should also be hidden. cc @donaldkibet @slubwama @makombe @ojwanganto

[jabahum]

@donaldkibet is this happening only on my side or its cutting across

Screen.Recording.2024-10-10.at.14.39.19.mov

[donaldkibet]

from above if the global property is true/false i think under userrole scopes the operation should also be hidden. cc @donaldkibet @slubwama @makombe @ojwanganto

IMO we are using the global property to hide stock issue as an independent function without having to perform requisition. What happens once a requisition has been performed and the main store or other place wants to issue an item but lack the permissions.

[donaldkibet]

@donaldkibet is this happening only on my side or its cutting across
Screen.Recording.2024-10-10.at.14.39.19.mov

Thanks for this catch, I think its affecting some endpoints not to return some values. I will investigate and revert back