Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance stock user roles to display all tagged locations. #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabriel090
Copy link
Contributor

Enhance stock user roles to display all locations for improved UX, ensuring usability with long lists.
Description:

Currently, when assigning user roles for stock management, users face challenges when the location list is extensive. This enhancement aims to optimize the user experience by displaying all locations efficiently, preventing usability blocks.

Acceptance Criteria:
1. Display all locations in a scrollable format within the user role assignment screen.
2. Ensure that the interface remains responsive and usable even with a large number of locations.
3. Validate changes across different screen resolutions and devices to maintain consistency.
Screenshot from 2024-08-17 12-55-51

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
    The modified solution
location.mp4

Summary

Screenshots

Related Issue

Other

@donaldkibet donaldkibet requested review from jabahum, makombe and hadijahkyampeire and removed request for jabahum and makombe August 19, 2024 05:16
@ojwanganto
Copy link

Kindly create a ticket for this and update it in the ticket

@hadijahkyampeire
Copy link
Contributor

hadijahkyampeire commented Aug 21, 2024

@gabriel090 please rewrite you PR title to match the PR conventions and link a ticket to it.

@gabriel090 gabriel090 changed the title Enhance stock user roles to display all locations for improved UX, en… Enhance stock user roles to display all tagged locations. Aug 21, 2024
@gabriel090
Copy link
Contributor Author

@gabriel090 please rewrite you PR title to match the PR conventions and link a ticket to it.

Thanks. I have modified.

@gabriel090
Copy link
Contributor Author

Kindly create a ticket for this and update it in the ticket

Note. Thanks

Copy link
Collaborator

@jabahum jabahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make the scrollable container expand to the entire view horizontally and also

@jabahum
Copy link
Collaborator

jabahum commented Aug 21, 2024

@gabriel090 i am of view we use a searchable dropdown instead this coz i can see there's alot extra space left on the right after the list.

@ojwanganto
Copy link

@jabahum - Can a searchable drop down support the toggle feature I see in the video?

@jabahum
Copy link
Collaborator

jabahum commented Aug 21, 2024

@jabahum - Can a searchable drop down support the toggle feature I see in the video?

it can if they are separate components and we just need to check for which item is selected then we can display the toggle.

@ojwanganto
Copy link

OK. What if we just make the location list searchable and retain the current implementation? I tend to like the current grouping of location and the toggle but it doesn't matter if your proposal will still achieve the same

@jabahum
Copy link
Collaborator

jabahum commented Aug 21, 2024

OK. What if we just make the location list searchable and retain the current implementation? I tend to like the current grouping of location and the toggle but it doesn't matter if your proposal will still achieve the same

am mostly worried about the extra spacing we already have that is not being used.

@ojwanganto
Copy link

Kindly create a ticket for this and update it in the ticket

Note. Thanks

Please update this to indicate the ticket

@makombe
Copy link
Contributor

makombe commented Dec 9, 2024

@gabriel090 You have conflicts and would you still want to move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants