(feat) O3-4332: Add linkify support for attachments description #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaishSiddharth
changed the title
vasharma05
changed the title
vasharma05
approved these changes
Jan 9, 2025
|
@ibacher @denniskigen @usamaidrsk, please review this PR. |
|
This needs a ticket created documenting why we're adding this feature. Otherwise, LGTM. Ticket needs to be created and referenced in this PR before this is mergeable. |
vasharma05
changed the title
vasharma05
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR uses the
linkify-reactlibrary to find out links in the attachment description and make them clickable.Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4332
Other