(fix) O3-4294: Fix incorrect visit date validation in edit mode in the visit form #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a condition that was incorrectly bypassing start date validation when `displayVisitStopDateTimeFields` is true. Start dates should always be validated to be on or before the current date, regardless of whether stop date fields are displayed.
|
Size Change: -61 B (0%) Total Size: 16 MB ℹ️ View Unchanged
|
denniskigen
commented
Dec 19, 2024
| @@ -157,7 +156,8 @@ const StartVisitForm: React.FC<StartVisitFormProps> = ({ | |||
| (value) => { | |||
| const today = dayjs(); | |||
| const startDate = dayjs(value); | |||
| return displayVisitStopDateTimeFields ? true : startDate.isSameOrBefore(today, 'day'); | |||
There was a problem hiding this comment.
This is the actual fix. The rest of the diff just reorganizes imports.
denniskigen
changed the title
denniskigen
requested review from
ibacher,
vasharma05,
samuelmale,
jayasanka-sack and
brandones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR fixes a bug in the visit form that allows users to set future start dates when editing visits. This happens because the start date validation was getting bypassed when the
displayVisitStopDateTimeFieldswas true (which is the case when editing an existing visit).Start dates should always be validated to be on or before the current date, regardless of whether stop date fields are displayed. This fix ensures that that is the case.
Screenshots
Visit start date validation not taking effect when editing an existing visit
visit-start-time-validation-bug.mp4
Fix
start-date-validation-fix.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-4294
Other