(fix) O3-4274: Use useRef instead of useState for useVisitFormCallbacks #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandones
changed the title
brandones
requested changes
Dec 15, 2024
There was a problem hiding this comment.
Thanks for this change, @Bharath-K-Shetty . Please clean up your code before submitting it. Remove the extra whitespace and strange comments.
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Show resolved
Hide resolved
| patientUuid={patientUuid} | ||
| visitFormOpenedFrom={openedFrom} | ||
| setVisitFormCallbacks={setVisitFormCallbacks} | ||
|
|
||
| visitFormCallbacksRef={visitFormCallbacksRef} // Pass the ref instead |
There was a problem hiding this comment.
Don't include comments that won't make sense to someone reading this code later. The whole point of comments is to make code less confusing.
There was a problem hiding this comment.
Sorry for that.I will remove the unnecessary comments and whitespaces.Thankyou for the feedback..!
|
Please add a video demonstrating that everything still behaves as expected. |
….component.tsx Co-authored-by: Brandon Istenes <[email protected]>
….component.tsx Co-authored-by: Brandon Istenes <[email protected]>
denniskigen
force-pushed
the
fix/O3-4274
branch
from
783de5b to
7945ebd
Compare
|
Hey @brandones,I’ve made the changes as requested and updated the PR. Let me know if any further changes are needed. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR refactors the useVisitFormCallbacks hook by replacing the usage of useState with useRef. The primary goal of this change is to improve performance by avoiding unnecessary re-renders triggered by state updates. useRef is used to persist values across renders without causing re-renders, which is particularly beneficial in the case of form callbacks where state persistence is needed but without affecting component lifecycle.
This change ensures that the form callbacks are maintained correctly across renders, while reducing the overhead associated with state management in React.
Jira Issue: O3-4274
Screenshots
O3-4274.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-4274
Other