-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor) O3-3846: Replace the DatePickers to use the OpenmrsDatePicker #2154
base: main
Are you sure you want to change the base?
Conversation
packages/esm-patient-chart-app/src/mark-patient-deceased/mark-patient-deceased-form.scss
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-date-time.component.tsx
Show resolved
Hide resolved
packages/esm-patient-tests-app/src/test-results/print-modal/print-modal.extension.tsx
Outdated
Show resolved
Hide resolved
83b8b3b
to
0b16f3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jwnasambu! Left a few nitpicks:
...ges/esm-patient-chart-app/src/mark-patient-deceased/mark-patient-deceased-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-conditions-app/src/conditions/conditions-widget.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-conditions-app/src/conditions/conditions-widget.component.tsx
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/components/orders-details-table.component.tsx
Show resolved
Hide resolved
packages/esm-patient-programs-app/src/programs/programs-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-tests-app/src/test-results/print-modal/print-modal.extension.tsx
Show resolved
Hide resolved
25100b4
to
a111ec8
Compare
packages/esm-patient-tests-app/src/test-results/print-modal/print-modal.extension.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-tests-app/src/test-results/print-modal/print-modal.extension.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-programs-app/src/programs/programs-form.workspace.tsx
Outdated
Show resolved
Hide resolved
…tePicker component across entire EMR
381a91d
to
1583d36
Compare
…-chart into feat/O3-3846
@ibacher One thing I am picking from the error I am getting on this PR is |
Try using this stub implementation of the import { OpenmrsDatePicker } from '@openmrs/esm-framework';
const mockOpenmrsDatePicker = jest.mocked(OpenmrsDatePicker);
mockOpenmrsDatePicker.mockImplementation(({ id, labelText, value, onChange }) => {
return (
<>
<label htmlFor={id}>{labelText}</label>
<input
aria-label={labelText.toString()}
id={id}
onChange={(evt) => {
onChange(dayjs(evt.target.value).toDate());
}}
type="text"
// @ts-ignore
value={value ? dayjs(value).format('DD/MM/YYYY') : ''}
/>
</>
);
}); |
@jwnasambu Standardize the use of the OpenMRS date picker Across All Apps O3-4287 however you are working on it . I checked what are changes you made . you already working on the visits, medication,conditions,Immunization,program,and other I think you did not worked on the Appointments so please work on it also Thank you . |
Requirements
Summary
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3846
Other